From 887d5db635c26ef9e367697e8db132bd64f06093 Mon Sep 17 00:00:00 2001 From: Mario Fink Date: Mon, 7 Aug 2023 22:50:00 +0200 Subject: [PATCH] add docu and fix github workflow pypi-deploy.yml for installing libiconv --- .github/workflows/pypi-deploy.yml | 17 ++++++++--------- README.md | 3 +++ 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/.github/workflows/pypi-deploy.yml b/.github/workflows/pypi-deploy.yml index 35581d8..17c0a77 100644 --- a/.github/workflows/pypi-deploy.yml +++ b/.github/workflows/pypi-deploy.yml @@ -40,16 +40,15 @@ jobs: with: name: wheel-config path: python/ - - name: Install iconv for Windows + - name: Get vcpkg repo if: matrix.os == 'windows-2019' - steps: - - name: Get vcpkg repo - run: git clone https://github.com/Microsoft/vcpkg.git - - name: Install vcpkg - run: .\vcpkg\bootstrap-vcpkg.bat - working-directory: vcpkg/ - - name: Install required package libiconv - run: vcpkg install libiconv + run: git clone https://github.com/Microsoft/vcpkg.git + - name: Build and install vcpkg and install libiconv for windows + if: matrix.os == 'windows-2019' + run: | + .\vcpkg\bootstrap-vcpkg.bat + vcpkg install libiconv + working-directory: vcpkg/ - name: Build wheels run: python -m cibuildwheel --output-dir wheelhouse working-directory: python/ diff --git a/README.md b/README.md index a796e01..4b16e96 100644 --- a/README.md +++ b/README.md @@ -233,3 +233,6 @@ can be found in the `python/examples` folder. - https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstepsrun - https://github.com/pypa/cibuildwheel/blob/main/examples/github-deploy.yml - https://cibuildwheel.readthedocs.io/en/stable/deliver-to-pypi/ +- https://www.gnu.org/software/libiconv/ +- https://vcpkg.io/en/packages.html +- https://vcpkg.io/en/getting-started